Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(privacy): Add a storage option #320

Merged
merged 2 commits into from
Dec 9, 2020
Merged

feat(privacy): Add a storage option #320

merged 2 commits into from
Dec 9, 2020

Conversation

pcorpet
Copy link
Contributor

@pcorpet pcorpet commented Nov 11, 2020

Summary

As discussed in #317, this PR creates a new option storage to be able to use sessionStorage for persisting the amplitude IDs with the session storage or even noneto not persist anything. These are options are useful for privacy as callers of the Amplitude lib can now limit the persistant footprints on users' browsers.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

@pcorpet pcorpet changed the title (feat): Add a storage option fate(privacy): Add a storage option Nov 11, 2020
@pcorpet pcorpet changed the title fate(privacy): Add a storage option feat(privacy): Add a storage option Nov 11, 2020
@kelvin-lu kelvin-lu self-requested a review November 12, 2020 00:39
@kelvin-lu kelvin-lu self-assigned this Nov 12, 2020
@kelvin-lu kelvin-lu requested a review from jooohhn November 12, 2020 00:39
kelvin-lu
kelvin-lu approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@kelvin-lu kelvin-lu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton for this PR! This looks good and thanks for updating the tests as well!

jooohhn
jooohhn approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@jooohhn jooohhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pcorpet, we'll merge this

@jooohhn jooohhn merged commit 1a56a9b into amplitude:master Dec 9, 2020
github-actions bot pushed a commit that referenced this pull request Jan 6, 2021
@amplitude-sdk-bot
chore(release): 7.4.0 [skip ci]
9861f15 
# [7.4.0](v7.3.3...v7.4.0) (2021-01-06)

### Features

* **privacy:** Add `storage` option ([#320](#320)) ([1a56a9b](1a56a9b)), closes [#317](#317)
* Added Fbclid config option ([#338](#338)) ([f52288a](f52288a))
@jooohhn jooohhn mentioned this pull request Feb 24, 2021
Merged
1 task
@emilieguth emilieguth deleted the master branch May 28, 2021 08:52
@pcorpet pcorpet mentioned this pull request Jan 19, 2022
Merged
8 tasks
@Nikitina-Ann Nikitina-Ann mentioned this pull request Nov 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelvin-lu kelvin-lu kelvin-lu approved these changes

@jooohhn jooohhn jooohhn approved these changes

Assignees

@kelvin-lu kelvin-lu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcorpet @jooohhn @kelvin-lu