Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make snippet public in NPM #478

Merged
merged 1 commit into from
Jan 7, 2022
Merged

feat: make snippet public in NPM #478

merged 1 commit into from
Jan 7, 2022

Conversation

jooohhn
Copy link
Contributor

@jooohhn jooohhn commented Jan 7, 2022

Summary

Makes amplitude-snippet.min.js public in our NPM distribution. Used so that we can embed latest version of snippet into our dev docs

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: NO

@jooohhn jooohhn requested a review from kevinpagtakhan January 7, 2022 18:23
@jooohhn jooohhn changed the title fix: remove snippet form npmignore feat: make snippet public in NPM Jan 7, 2022
@jooohhn jooohhn force-pushed the fix-public-snippet branch from 357fdc6 to 791e4d2 Compare January 7, 2022 18:24
Copy link
Contributor

@kevinpagtakhan kevinpagtakhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jooohhn jooohhn merged commit 8f512f0 into main Jan 7, 2022
@jooohhn jooohhn deleted the fix-public-snippet branch January 7, 2022 21:06
github-actions bot pushed a commit that referenced this pull request Jan 7, 2022
# [8.15.0](v8.14.1...v8.15.0) (2022-01-07)

### Features

* make snippet public in NPM ([#478](#478)) ([8f512f0](8f512f0))
@github-actions
Copy link

github-actions bot commented Jan 7, 2022

🎉 This PR is included in version 8.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants