Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add partner_id support #545

Merged
merged 1 commit into from
Jul 25, 2022
Merged

feat: add partner_id support #545

merged 1 commit into from
Jul 25, 2022

Conversation

qingzhuozhen
Copy link
Contributor

@qingzhuozhen qingzhuozhen commented Jul 24, 2022

Summary

  • add partner_id support

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

Copy link
Contributor

@haoliu-amp haoliu-amp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a doc change needed?

@qingzhuozhen
Copy link
Contributor Author

Good point, we have the comments doc and can run the action to update the code reference.

@haoliu-amp
Copy link
Contributor

Good point, we have the comments doc and can run the action to update the code reference.

How about the amplitude dev doc? Does this need to get mentioned there?

@qingzhuozhen
Copy link
Contributor Author

Right now we don't list all the options for JS, more point to our options page. I could add one section for it if we prefer highlighting this change.

@qingzhuozhen qingzhuozhen merged commit 7b343ea into main Jul 25, 2022
@qingzhuozhen qingzhuozhen deleted the partner-id-support branch July 25, 2022 16:53
github-actions bot pushed a commit that referenced this pull request Jul 25, 2022
# [8.19.0](v8.18.5...v8.19.0) (2022-07-25)

### Features

* add partner_id support ([#545](#545)) ([7b343ea](7b343ea))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants