fix: skip top domain when cookie is disabled #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuyang1520
force-pushed
the
fix-disable-cookies-misses
branch
from
81d2ac1 to
0d64a4b
Compare
liuyang1520
requested review from
yuhao900914,
qingzhuozhen,
justin-fiedler and
kevinpagtakhan
qingzhuozhen
approved these changes
Mar 6, 2023
kevinpagtakhan
approved these changes
Mar 6, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Mar 7, 2023
## [8.21.6](v8.21.5...v8.21.6) (2023-03-07) ### Bug Fixes * skip top domain when cookie is disabled ([#580](#580)) ([a9ff324](a9ff324))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For test cookie, we have the random id each time when testing whether the cookie is enabled in the browser, this might introduce too many cookies if the remove operation gets any issue. Following the TS SDK, think we can just use the general key for testing purpose.
With
disabledCookiesset totrue, we still have atopDomainfunction which still uses the cookies (base-cookie):getLocationandgetHostto utils, so we can mock/stub the functions, otherwise aswindow.locationis not writable/configurable, we cannot unit test the features, also moving these two standalone functions into utils for better readability.topDomaininMetadataStoragewhen cookies is disabled.Checklist