Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMP Stories] Create the base templates for Travel and Fandom #2010

Closed
2 tasks done
miina opened this issue Mar 21, 2019 · 6 comments
Closed
2 tasks done

[AMP Stories] Create the base templates for Travel and Fandom #2010

miina opened this issue Mar 21, 2019 · 6 comments
Milestone

Comments

@miina
Copy link
Contributor

miina commented Mar 21, 2019

AC: User can select between X (to be selected from the designs) single-page templates which are pre-populated with blocks, images and other data, so that they make sense in the context of Travel / Fandom;

  • Create templates in the editor based on design, use the HTML source to create templates for the "Template Inserter";
  • Auto-import pre-existing templates if the templates have never been imported before.
@amedina
Copy link
Member

amedina commented Mar 21, 2019

The goal here would be to abstract the components that would form a Fandom template. This encompasses:

  • Consider the case of multi-page templates (used when starting a story), and single-page templates (used at any point during story creation, possibly with special cases for first page, middle page, last page (bookend)
  • For Travel/Fandom, what would the building blocks commonly found in travel or fandom stories
  • Which combinations of them would make sense from a UX POV? Each of these combinations would form a template page.
  • Which combination of template pages would go well together? Each of these sets of pages would form a multi-page templates.

@miina @swissspidy @westonruter @dawidmlynarz @kienstra

@miina miina self-assigned this Mar 29, 2019
@miina miina closed this as completed Apr 22, 2019
@miina miina assigned csossi and unassigned miina Apr 22, 2019
@csossi
Copy link

csossi commented May 8, 2019

Any instructions re: testing for this? Not sure what I'm looking at here

@csossi csossi assigned miina and unassigned csossi May 8, 2019
@miina
Copy link
Contributor Author

miina commented May 9, 2019

Testing Instructions

  • When clicking on the Template Inserter, 4 templates have to be available. Template Inserter:
    Screen Shot 2019-05-09 at 9 49 11 AM

  • It has to be possible to insert a blank page from the template inserter, too.

  • When clicking on any of the templates in the template inserter, the template with all the blocks that can be seen in template inserter have to be inserted to the editor.

  • The placement of the blocks should be the same as in the preview within the template inserter, however, no images should be inserted, and there should be placeholders instead of the texts.

Let me know if there are any doubts. cc @csossi

@miina miina assigned csossi and unassigned miina May 9, 2019
@csossi
Copy link

csossi commented May 14, 2019

Thanks, @miina

Can anything be done regarding these two templates? There's a purple vertical bar and copy overlapping it that looks confusing:
image

image

@miina
Copy link
Contributor Author

miina commented May 15, 2019

@csossi Could you test again?

@miina miina closed this as completed May 15, 2019
@miina miina assigned csossi and unassigned miina May 15, 2019
@csossi
Copy link

csossi commented May 15, 2019

Verified in QA:
image
image
image

@csossi csossi removed their assignment May 15, 2019
@westonruter westonruter added this to the v1.2 milestone May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants