Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TwentyTwenty modal admin bar offset is targeting wrong class #3569

Closed
schlessera opened this issue Oct 21, 2019 · 1 comment · Fixed by #3574
Closed

TwentyTwenty modal admin bar offset is targeting wrong class #3569

schlessera opened this issue Oct 21, 2019 · 1 comment · Fixed by #3574
Labels
Bug Something isn't working CSS Sanitizers
Milestone

Comments

@schlessera
Copy link
Collaborator

schlessera commented Oct 21, 2019

Bug Description

The TwentyTwenty theme compat code needs to add a CSS offset to a modals when the admin bar is shown, so that they are not partially obscured by the admin bar.

The current code targets a specific modal, though (.menu-modal), instead of all modals (.cover-modal).

This causes the search modal to be stuck behind the admin bar still.

Expected Behaviour

All modals should be offset to account for the admin bar.

Steps to reproduce

  1. Open a twentytwenty-themed site at any AMP URL.
  2. Click on the magnifying glass in the header bar to open the search modal.

Screenshots

Image 2019-10-21 at 12 55 16 PM


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@csossi
Copy link

csossi commented Oct 29, 2019

Verified in QA:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working CSS Sanitizers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants