Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several AMP dev dependencies are deprecated #11303

Closed
rsimha opened this issue Sep 15, 2017 · 1 comment · Fixed by #11332
Closed

Several AMP dev dependencies are deprecated #11303

rsimha opened this issue Sep 15, 2017 · 1 comment · Fixed by #11332

Comments

@rsimha
Copy link
Contributor

rsimha commented Sep 15, 2017

Now that we're no longer using yarn to manage dependencies, I deleted my node_modules directory and reinstalled everything via npm prune && npm install to see if the AMP dev workflow works for new committers.

Of the deprecated dependencies, some are indirectly pulled in by other dev dependencies, but I'm sure we can update them to no longer have deprecation warnings.

rsimha@rsimha-macbookpro3 (2017-09-15-Yarn):~/src/amphtml$ rm -rf node_modules/
rsimha@rsimha-macbookpro3 (2017-09-15-Yarn):~/src/amphtml$ npm prune && npm install
npm WARN deprecated [email protected]: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated [email protected]: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated [email protected]: Use uuid module instead
npm WARN deprecated [email protected]: ReDoS vulnerability parsing Set-Cookie https://nodesecurity.io/advisories/130
npm WARN deprecated [email protected]: We're super 😸  excited that you're trying to use ES2015 syntax, but instead of making more yearly presets 😭 , Babel now has a better preset that we recommend you use instead: npm install babel-preset-env --save-dev. preset-env without options will compile ES2015+ down to ES5 just like using all the presets together and thus is more future proof. It also allows you to target specific browsers so that Babel can do less work and you can ship native ES2015+ to user 😎 ! We are also in the process of releasing v7, so please give http://babeljs.io/blog/2017/09/12/planning-for-7.0 a read and help test it out in beta! Thanks so much for using Babel 🙏, please give us a follow on Twitter @babeljs for news on Babel, join slack.babeljs.io for discussion/development and help support the project at opencollective.com/babel
npm WARN deprecated [email protected]: to-iso-string has been deprecated, use @segment/to-iso-string instead.
npm WARN deprecated [email protected]: Jade has been renamed to pug, please install the latest version of pug instead of jade
npm WARN engine [email protected]: wanted: {"node":">=6"} (current: {"node":"4.8.4","npm":"2.15.11"})
npm WARN deprecated [email protected]: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated [email protected]: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated [email protected]: graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to graceful-fs@^4.0.0 as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.
@rsimha
Copy link
Contributor Author

rsimha commented Sep 21, 2017

Updates:

  1. Since Replace npm with yarn #11332, we are now back to using yarn for package management.
  2. With Enforce the use of yarn for package management #11368, we enforce the use of yarn over npm install.
  3. yarn.lock and package.json have been updated and are in sync.

With this, deleting node_modules and reinstalling all packages results in the following output:

Linux:

rsimha@bobdylan (master):~/src/amphtml$ yarn
yarn install v1.0.2
$ node build-system/check-package-manager.js
Detected yarn. Installing packages...
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
info [email protected]: The platform "linux" is incompatible with this module.
info "[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
[4/5] Linking dependencies...
warning "[email protected]" has incorrect peer dependency "ajv@>=4.10.0".
[5/5] Building fresh packages...
Done in 12.68s.

MacOS:

rsimha@rsimha-macbookpro3 (master):~/src/amphtml$ yarn
yarn install v1.0.2
$ node build-system/check-package-manager.js
Detected yarn. Installing packages...
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
[4/5] 🔗  Linking dependencies...
warning "[email protected]" has incorrect peer dependency "ajv@>=4.10.0".
[5/5] 📃  Building fresh packages...
✨  Done in 220.40s.

The warning from ajv-keywords is noise, due to an outdated transitive dependency in a 3rd party package, and can safely be ignored. See yarnpkg/yarn#4064

Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants