Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate strategy for dependency pinning #2771

Closed
cramforce opened this issue Mar 31, 2016 · 5 comments
Closed

Investigate strategy for dependency pinning #2771

cramforce opened this issue Mar 31, 2016 · 5 comments

Comments

@cramforce
Copy link
Member

We used to use NPM shrinkwrap, but we stopped due to problems with @greenkeeperio-bot. We should reconsider. I'd also consider just checking node_modules into the repo (or ideally a separate repo connected with git submodule (Rule number 1: Never ever use git submodule, they are the worst).

@erwinmombay
Copy link
Member

cool, will go ahead and run shrinkwrap again. these days we dont really upgrade as much we would like to anyways, so i think we should be good. we can always remove shrinkwrap again if it becomes a issue.

ive never done checking the whole node_modules into a repo, not sure whats its implications are building etc (besides cloning slowdown + bandwidth)

@ericlindley-g ericlindley-g added this to the Backlog milestone Mar 31, 2016
@cramforce cramforce reopened this Feb 11, 2017
@cramforce
Copy link
Member Author

@erwinmombay where are we with yarn on this?

@erwinmombay
Copy link
Member

@cramforce confirmed it works internally in the release process. i need to update the docs and send out an email to the team

@adelinamart
Copy link
Contributor

@erwinmombay anything else to be done here? Thanks

@dreamofabear
Copy link

This should be fixed for good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants