Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time picker steals focus and clears input on pressing enter in another form input #223

Closed
wants to merge 4 commits into from

Conversation

lalitkapoor
Copy link
Contributor

Reproduced here:
http://jsfiddle.net/2pspY/8/

Steps to reproduce:

have 3 input elements: one for date, one for time, one other input field

  1. Pick a date
  2. Pick a time
  3. Type something in the other element if desired
  4. Press enter key while focus is on the other element

Browser: Chrome version 29.0.1547.65
OS: OS X 10.8.3
Pickadate.js: version 3.2.1

@lalitkapoor
Copy link
Contributor Author

looks like failing tests are unrelated to this issue.

@lalitkapoor
Copy link
Contributor Author

@amsul can I get some lovin' on this pull request :) Thanks!

@amsul
Copy link
Owner

amsul commented Sep 12, 2013

Oh, what a silly mistake.. thanks for this! I’ll merge it in soon.

Cheers!

@lalitkapoor
Copy link
Contributor Author

@amsul hey, any updates on this? Anything I can do to make this go faster? Thanks

@lalitkapoor
Copy link
Contributor Author

@amsul I'm going to have to register my fork to bower because I need it for some deployments now, please let me know when you do merge this in, so I can switch back to this. Thanks.

@amsul
Copy link
Owner

amsul commented Sep 20, 2013

@lalitkapoor I apologize for the lack of response – been feeling quite under the weather these last few days. I just pushed a compiled version to the edge branch. Will merge in soon along with a few other fixes :)

@amsul
Copy link
Owner

amsul commented Sep 20, 2013

Fixed.

@amsul amsul closed this Sep 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants