Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when loading a dbc file #35

Open
bigoulours opened this issue Jul 23, 2019 · 3 comments
Open

Crash when loading a dbc file #35

bigoulours opened this issue Jul 23, 2019 · 3 comments

Comments

@bigoulours
Copy link

bigoulours commented Jul 23, 2019

Hi,

I found your program and the interface seems cool. Unfortunately loading a dbc-file leads to crash.
I tried releases back to 468 and same problem occurs.

@bigoulours bigoulours changed the title Crash when oading a dbc file Crash when loading a dbc file Jul 23, 2019
@amund7
Copy link
Owner

amund7 commented Jul 26, 2019

Hi,

the software will load a wide variety of DBC files. However, one file that I've tried crashes. I fixed one crash, but it got lost in github submodules that overwrites eachother.

If you can cut down the DBC file to find out where it crashes, then send us a short and sweet DBC (or create a dummy) that triggers the crash would be great.

@bigoulours
Copy link
Author

bigoulours commented Jul 31, 2019

Hi,

I played around with my dbc and found out the lines causing the problem.
At the end of the file, there are several lines beginning with "BA_" (e.g.: BA_ "GenMsgSendType" BO_ 534 1;)
If I delete them, the dbc loads correctly.
I don't know how often these lines are found in dbc but maybe your program could ignore them?

Keep up the good work!

EDIT: there are several lines beginning with BA_ (BA_DEF_, BA_DEF_DEF_) I will try to narrow down where exactly the problem lies

@bigoulours
Copy link
Author

OK so in my case, the particular line causing problem was:
BA_DEF_ SG_ "GenSigStartValue" FLOAT 0 0;

It's the only line starting with BA_DEF_ SG_
Other lines starting with BA_ (BA_DEF_, BA_DEF_ BO_, BA_DEF_DEF_) are handled fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants