Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct typo in Snowflake Last Updated extract query #358

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

ajbosco
Copy link
Contributor

@ajbosco ajbosco commented Sep 2, 2020

https://docs.snowflake.com/en/sql-reference/functions/date_part.html

Summary of Changes

Include a summary of changes then remove this line

Tests

What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line

Documentation

What documentation did you add or modify and why? Add any relevant links then remove this line

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

@feng-tao feng-tao changed the title fix - correct typo in Snowflake Last Updated extract query fix: correct typo in Snowflake Last Updated extract query Sep 2, 2020
@feng-tao
Copy link
Member

feng-tao commented Sep 2, 2020

thanks @ajbosco , could you run git commit --amend --signoff and repush the pr which will fix the DCO error?

@feng-tao feng-tao merged commit 5c2e98e into amundsen-io:master Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants