Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sample_glue_loader script #366

Merged
merged 2 commits into from
Sep 14, 2020
Merged

feat: add sample_glue_loader script #366

merged 2 commits into from
Sep 14, 2020

Conversation

higee
Copy link
Contributor

@higee higee commented Sep 14, 2020

Summary of Changes

Add a sample script to load AWS Glue data to Neo4j and to Elasticsearch by following amundsen-io/amundsen#542. Make sure your AWS user has access to perform glue:SearchTables. If you are assuming specific role, try editing glue_extractor.py to the following.

self._glue = boto3.Session(profile_name='YOUR_PROFILE_NAME').client('glue')

Tests

No tests for the sample scripts.

Documentation

No documentation added

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

@feng-tao feng-tao changed the title feat : add sample_glue_loader script feat: add sample_glue_loader script Sep 14, 2020
@feng-tao
Copy link
Member

thanks, could you do git commit --amend --signoff in your local branch and repush your pr? This should fix the DCO issue. thanks.

@higee
Copy link
Contributor Author

higee commented Sep 14, 2020

thanks, could you do git commit --amend --signoff in your local branch and repush your pr? This should fix the DCO issue. thanks.

Done 👍

@feng-tao
Copy link
Member

thanks @higee

@feng-tao feng-tao merged commit fa3f11b into amundsen-io:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants