feat: Make DescriptionMetadata inherit from GraphSerializable #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngyjd
requested review from
allisonsuarez,
dikshathakur3119,
feng-tao and
jinhyukchang
as code owners
dkunitsk
reviewed
Mar 25, 2021
feng-tao
reviewed
Mar 25, 2021
| @@ -117,7 +117,7 @@ def _create_record_iterator(self) -> Iterator[RDSModel]: | |||
|
|
|||
|
|
|||
| # TODO: this should inherit from ProgrammaticDescription in amundsen-common | |||
| class DescriptionMetadata: | |||
| class DescriptionMetadata(GraphSerializable): | |||
There was a problem hiding this comment.
hey @youngyjd , @crazy-2020 recently added https://github.com/amundsen-io/amundsendatabuilder/blob/master/databuilder/models/table_serializable.py#L10 to allow databuilder for mysql, could you make it as subclass as well.
There was a problem hiding this comment.
actually will let @crazy-2020 comment
There was a problem hiding this comment.
thanks @feng-tao. I think it's fine to inherit only graph serializable in DescriptionMetadata. rds models do not have a single generic description model used for multiple entities.
dkunitsk
reviewed
Mar 25, 2021
| @@ -165,10 +179,12 @@ def get_description_id(self) -> str: | |||
| else: | |||
| return "_" + self.source + "_description" | |||
|
|
|||
| def __repr__(self) -> str: | |||
| return f'DescriptionMetadata({self.source!r}, {self.text!r})' | |||
| def get_description_default_key(self, start_key: Optional[str]) -> Optional[str]: | |||
There was a problem hiding this comment.
dkunitsk
reviewed
Mar 25, 2021
Signed-off-by: Junda Yang <[email protected]>
Signed-off-by: Junda Yang <[email protected]>
Signed-off-by: Junda Yang <[email protected]>
youngyjd
force-pushed
the
description-metadata-inherit-graphserializable
branch
from
c2f0ac5 to
daffa92
Compare
Signed-off-by: Junda Yang <[email protected]>
youngyjd
force-pushed
the
description-metadata-inherit-graphserializable
branch
from
51eaf4e to
6ebbe40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Make DescriptionMetadata inherit from GraphSerializable. The change is backward compatible. DescriptionMetadata can still be created along with TableMetadata, ColumnMetadata, or SchemaModel. At the same time, DescriptionMetadata can now created independently, as long as node key, relation start key, relation start label are provided.
Tests
CheckList
Make sure you have checked all steps below to ensure a timely review.
make test