Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Get last updated ts for AtlasProxy #177

Merged

Conversation

mgorsk1
Copy link
Contributor

@mgorsk1 mgorsk1 commented Aug 24, 2020

Signed-off-by: mgorsk1 [email protected]

Summary of Changes

Add support for get_latest_updated_ts in AtlasProxy

Tests

What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line

Documentation

What documentation did you add or modify and why? Add any relevant links then remove this line

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

@mgorsk1 mgorsk1 requested a review from verdan August 24, 2020 08:18
Copy link
Member

@verdan verdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add the test case for this?

@mgorsk1 mgorsk1 force-pushed the feature/get_latest_updated_ts_atlas_proxy branch from 360300c to c91eb37 Compare August 25, 2020 06:32
@mgorsk1
Copy link
Contributor Author

mgorsk1 commented Aug 25, 2020

@verdan tests added

@mgorsk1 mgorsk1 requested a review from verdan August 25, 2020 06:33
Copy link
Member

@verdan verdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mgorsk1 mgorsk1 merged commit 3e92586 into amundsen-io:master Aug 25, 2020
@mgorsk1 mgorsk1 deleted the feature/get_latest_updated_ts_atlas_proxy branch August 25, 2020 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants