Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Proxy client creation fails after adding client_kwargs #258

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

mgorsk1
Copy link
Contributor

@mgorsk1 mgorsk1 commented Feb 4, 2021

Signed-off-by: mgorsk1 [email protected]

Summary of Changes

Fix after adding additional kwarg to client create method

Tests

Added tests for get_client method

Documentation

n/a

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

Signed-off-by: mgorsk1 <[email protected]>
@mgorsk1 mgorsk1 force-pushed the fix/client_creation branch from cfe6d66 to bf1404c Compare February 4, 2021 20:28
@feng-tao feng-tao merged commit 1880cec into amundsen-io:master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants