-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Column Badge API #273
feat: Add Column Badge API #273
Conversation
2baa8a8
to
c69b0d0
Compare
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
==========================================
+ Coverage 74.10% 77.64% +3.54%
==========================================
Files 25 27 +2
Lines 1255 1387 +132
Branches 136 163 +27
==========================================
+ Hits 930 1077 +147
+ Misses 297 263 -34
- Partials 28 47 +19
Continue to review full report at Codecov.
|
6e6f1aa
to
752888b
Compare
346cd0c
to
56eb593
Compare
Would love to get Dmitriy's code to get merged fixing amundsen-io/amundsen#939 before merging this. |
amundsen-io/amundsen#939 should be fixed now (by amundsen-io/amundsen#951) |
Thanks @dkunitsk! Would love to get this in the new release then 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Signed-off-by: adoami <[email protected]>
Signed-off-by: adoami <[email protected]>
Signed-off-by: adoami <[email protected]>
Signed-off-by: adoami <[email protected]>
Signed-off-by: adoami <[email protected]>
Signed-off-by: adoami <[email protected]>
…#279) * fixes pip install and configs Signed-off-by: verdan <[email protected]> * cleanup Signed-off-by: verdan <[email protected]> * test fix Signed-off-by: verdan <[email protected]> * removes the requirements changes from branch Signed-off-by: verdan <[email protected]> Signed-off-by: adoami <[email protected]>
1af0217
to
054e1c4
Compare
Signed-off-by: adoami <[email protected]>
Signed-off-by: adoami <[email protected]>
Signed-off-by: adoami <[email protected]>
Signed-off-by: adoami <[email protected]>
Signed-off-by: adoami <[email protected]>
Signed-off-by: adoami <[email protected]>
Signed-off-by: adoami <[email protected]>
054e1c4
to
e8e27b2
Compare
Signed-off-by: adoami <[email protected]>
bc21a01
to
76aeeed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Signed-off-by: adoami <[email protected]>
a41ceff
to
3cd9a4d
Compare
thanks @alldoami |
Thanks @feng-tao! Should we merge amundsen-io/amundsen#962 too? I fixed the merge history 😄 |
Summary of Changes
Added Column Badge API that addresses this issue: amundsen-io/amundsen#944
Tests
Tested exactly how we're testing Table Badges right now.
Documentation
amundsen-io/amundsen#962
CheckList
Make sure you have checked all steps below to ensure a timely review.
make test