Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: archiver has been archived - replace with archives fork #2304

Closed
KimNorgaard opened this issue Dec 5, 2024 · 3 comments · Fixed by #2313
Closed

fix: archiver has been archived - replace with archives fork #2304

KimNorgaard opened this issue Dec 5, 2024 · 3 comments · Fixed by #2313
Assignees
Labels
bug Something isn't working security Vulnerabilities found in latest version of code

Comments

@KimNorgaard
Copy link

grype/go.mod

Line 44 in 37245b0

github.com/mholt/archiver/v3 v3.5.1

grype/go.mod

Line 271 in 37245b0

replace github.com/mholt/archiver/v3 v3.5.1 => github.com/anchore/archiver/v3 v3.5.2

The fork fixes security issues with the lates(last) version of archiver. The author has since rewritten the module (see https://github.com/mholt/archives) and may have fixed those issues upstream.

I am getting dependabot alerts on archiver through grype/syft and there is nothing I can do about them since the project has been archived.

@spiffcs
Copy link
Contributor

spiffcs commented Dec 5, 2024

Thanks @KimNorgaard - I'm so sorry that you're getting dependabot alerts on archiver from grype/syft.

There are a couple reasons we should be removing this replace line and we just have not gotten around to removing it. Again, apologies for the spurious errors and extra toil you're getting from relying on our libraries.

I'm going to first solidify our fork, update the go mod, and remove this replace with a tagged release of our fork.

That should immediately resolve the security issue.

Step two we will be checking the new upstream and see if it has all the functionality we need to migrate to. We have some people relying on our fork so we're going to want to handle that carefully.

@KimNorgaard
Copy link
Author

Thank you for the quick response. I completely understand your need to ensure backwards compatibility. I just wanted to give you a heads up and I'm happy you are looking into it.

@spiffcs spiffcs self-assigned this Dec 5, 2024
@spiffcs spiffcs moved this to In Progress in OSS Dec 5, 2024
@spiffcs spiffcs linked a pull request Dec 10, 2024 that will close this issue
@spiffcs
Copy link
Contributor

spiffcs commented Dec 10, 2024

We just merged two PRs to syft and grype that should close this issue against main

We'll do another release soon which will have a tagged version of these fixes.

@spiffcs spiffcs closed this as completed Dec 10, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in OSS Dec 10, 2024
@spiffcs spiffcs changed the title Archiver has been archived. Maybe replace with archives. fix: archiver has been archived - replace with archives fork Dec 13, 2024
@spiffcs spiffcs added bug Something isn't working security Vulnerabilities found in latest version of code labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working security Vulnerabilities found in latest version of code
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants