Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional Godot argument types #2

Open
follower opened this issue Mar 3, 2020 · 2 comments
Open

Support additional Godot argument types #2

follower opened this issue Mar 3, 2020 · 2 comments

Comments

@follower
Copy link
Contributor

follower commented Mar 3, 2020

Creating this issue as a way to keep track of adding support for more Godot argument types:

@follower
Copy link
Contributor Author

follower commented Mar 3, 2020

Re: PoolByteArray (and Pool*Array in general) the related implementation in godot-python might be informative: touilleMan/godot-python@e9347d6 (via)

Seems like the write access (at least) requires holding/destroying a lock.

(I also noted that the docs mentioned:

"Note: This type is passed by value and not by reference."

But I wasn't sure if this was only relevant at GDScript level or not.)

Edit: Add "via" link.

@follower
Copy link
Contributor Author

Re: PoolByteArray, in Godot 4.0 these become PackedByteArray etc and become references (& thus mutable) :

Packed arrays are now references in GDScript

Users often complained that PoolArrays were immutable types, so accessing them inside sub-arrays, dictionaries, etc. or passing them to/from functions would always create copies.

In the 4.x branch, besides no longer being pool based, they became references.
via

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant