Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mypy support #16

Open
matthewrfennell opened this issue Jan 1, 2024 · 2 comments
Open

Mypy support #16

matthewrfennell opened this issue Jan 1, 2024 · 2 comments

Comments

@matthewrfennell
Copy link

Would you be interested in me raising a PR to add mypy types to this library?

I'm using this library in a project I'm currently working on which runs mypy across the codebase. Currently, I have to instruct mypy not to check types coming from this library - but adding types to this library would let me remove this override.

PS - thanks for this library and the dirhash standard, it makes it so easy to generate hashes and be confident they will be consistent across environments.

@andhus
Copy link
Owner

andhus commented Jan 4, 2024

Hey @matthewrfennell Thanks for dropping by :) as of #9 I have very little time to maintain this unfortunately, but if you're willing to do so I'll find the time to review ...worried however that there might be some unrelated "blockers" (like Travis not running anymore etc.) that could slow it down. Haven't touched this in a long time and it could definitely use some spring cleaning.

@matthewrfennell
Copy link
Author

Ok, thanks a lot for getting back!
I need to get approval from my employer before contributing, so I'll start filling out the paperwork now :) but, hopefully it'll get accepted.
It may be a few weeks before I hear back from them - in the meantime I'll see if I can get it working locally.
Once I have a PR, if I can be of help for sorting out Travis or some other blockers, then I'd be happy to help there too! But no pressure either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants