Ensure DragRotate stops when the window looses focus. Fixes mapbox#3389…

… (mapbox#4390)

* Ensure DragRotate stops when the window looses focus. Fixes mapbox#3389

* simplify approach to de-activate DragRotate when the window loosese focus

* de-activate DragPan when window loosese focus

src/ui/handler/drag_pan.js

@@ -84,6 +84,8 @@ class DragPanHandler {
             window.document.addEventListener('mousemove', this._onMove);
             window.document.addEventListener('mouseup', this._onMouseUp);
         }
+        /* Deactivate DragPan when the window looses focus. Otherwise if a mouseup occurs when the window isn't in focus, DragPan will still be active even though the mouse is no longer pressed. */
+        window.addEventListener('blur', this._onMouseUp);
 
         this._active = false;
         this._startPos = this._pos = DOM.mousePos(this._el, e);
@@ -169,6 +171,7 @@ class DragPanHandler {
         this._onUp(e);
         window.document.removeEventListener('mousemove', this._onMove);
         window.document.removeEventListener('mouseup', this._onMouseUp);
+        window.removeEventListener('blur', this._onMouseUp);
     }
 
     _onTouchEnd(e) {
@@ -193,7 +196,7 @@ class DragPanHandler {
             if (e.ctrlKey) return true;
             const buttons = 1,  // left button
                 button = 0;   // left button
-            return (e.type === 'mousemove' ? e.buttons & buttons === 0 : e.button !== button);
+            return (e.type === 'mousemove' ? e.buttons & buttons === 0 : e.button && e.button !== button);
         }
     }
 

src/ui/handler/drag_rotate.js

@@ -82,6 +82,8 @@ class DragRotateHandler {
 
         window.document.addEventListener('mousemove', this._onMove);
         window.document.addEventListener('mouseup', this._onUp);
+        /* Deactivate DragRotate when the window looses focus. Otherwise if a mouseup occurs when the window isn't in focus, DragRotate will still be active even though the mouse is no longer pressed. */
+        window.addEventListener('blur', this._onUp);
 
         this._active = false;
         this._inertia = [[Date.now(), this._map.getBearing()]];
@@ -129,6 +131,7 @@ class DragRotateHandler {
         if (this._ignoreEvent(e)) return;
         window.document.removeEventListener('mousemove', this._onMove);
         window.document.removeEventListener('mouseup', this._onUp);
+        window.removeEventListener('blur', this._onUp);
 
         if (!this.isActive()) return;