Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Add Byte and Int16 Support #69

Closed
arex388 opened this issue May 23, 2022 · 3 comments
Closed

[Proposal] Add Byte and Int16 Support #69

arex388 opened this issue May 23, 2022 · 3 comments

Comments

@arex388
Copy link

arex388 commented May 23, 2022

I occasionally use byte and short as the backing type for an Id in SQL Server because int is just too large for my needs. It would be nice to have support for byte and short along side int and long for such scenarios.

Unless I'm missing something, as far as I can tell, I can't make a strongly typed id for those Ids with the current implementation of the library. I'll probably duplicate what the source generator is outputting manually so I can still get a strongly typed id, but it would be nice to have the library take care of those as well.

@andrewlock
Copy link
Owner

Yep, those are on the radar to add, just need to get round to it 🙂

@MirzaMerdovic
Copy link

@andrewlock if this is up for grabs, I would be happy to give it a go?

@andrewlock
Copy link
Owner

Sorry for the lack of attention on this, I got a bit burnt out over the requests with this library 😬 The good news is that for feature requests like this, I think I've found an answer in the big redesign of the library in this PR:

The main idea is to make the library much more maintainable while also giving people a mechanism to customise the generated IDs as much as they like. This will make it easy to make changes or additions like this 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants