Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test to check that all NDK headers are C compatible and warning free #1756

Open
DanAlbert opened this issue Aug 24, 2022 · 2 comments
Open

Comments

@DanAlbert
Copy link
Member

Description

I was fairly certain we already had this test, but we should verify this so that we don't have problems like #1739 again

@jmgao
Copy link
Contributor

jmgao commented Aug 25, 2022

versioner compiles headers as both gnu++11 and gnu11 (#440), with -Weverything so I'd guess it's not getting run for all of the NDK headers?

@DanAlbert
Copy link
Member Author

It's only libc (and only the core libc headers at that), and we're trying to get rid of versioner since it prevents #837 from working on those headers.

I suppose we could leave it but disable the preprocessing part of what it does, but I think it's probably not too hard to just write a test that does this (or modify ndk_headers to verify this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants