Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] remove --gc-sections from debug cmake variant with new toolchain file #1826

Open
DanAlbert opened this issue Jan 13, 2023 · 1 comment
Labels
bug cmake-new-toolchain Bugs for the "new" (not recommended) CMake toolchain file

Comments

@DanAlbert
Copy link
Member

Description

#1813 wasn't able to be fixed for the new toolchain file because CMake doesn't offer us that level of control. We need to get CMake fixed to allow us to fix this for that configuration.

Affected versions

r25, Canary

Canary version

No response

Host OS

Linux, Mac, Windows

Host OS version

any

Affected ABIs

armeabi-v7a, arm64-v8a, x86, x86_64

Build system

CMake

Other build system

No response

minSdkVersion

any

Device API level

No response

@rpavlik
Copy link

rpavlik commented Apr 10, 2023

Can this be done with generator expressions? $<IF:$<CONFIG:Debug>,,--gc-sections> or something like that should add the flag only when it's not in debug mode. I'm not 100% sure it works when put in the toolchain file level variables, but maybe...

@DanAlbert DanAlbert added the cmake-new-toolchain Bugs for the "new" (not recommended) CMake toolchain file label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cmake-new-toolchain Bugs for the "new" (not recommended) CMake toolchain file
Projects
None yet
Development

No branches or pull requests

2 participants