Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better visual desing #8

Closed
ai opened this issue Jun 2, 2016 · 81 comments
Closed

Better visual desing #8

ai opened this issue Jun 2, 2016 · 81 comments

Comments

@ai
Copy link

ai commented Jun 2, 2016

Out current UX is nice, but we need better visual design:

  1. Better fonts
  2. More modern controls

We could always try Material design, its visual langauge pretty nice and better then nothing (but custom visual design will be nicer).

With better visual design this tool will look more professional.

@Gaserd
Copy link
Contributor

Gaserd commented Jun 2, 2016

We can try Material design, but i dont like material design :)
What you like fonts ? Current font - Roboto, san-serif.

@ai
Copy link
Author

ai commented Jun 2, 2016

Yeap, I agree that Metarial is to mainstream :).

Hm, maybe font problem is already closed.

@Gaserd
Copy link
Contributor

Gaserd commented Jun 2, 2016

We can try, and see -> good Material design or not good :) In our case

@Gaserd
Copy link
Contributor

Gaserd commented Jun 2, 2016

I make Material design, but dont make "code area"

ScreenShot :
2016-06-02 17 14 31

@ai
Copy link
Author

ai commented Jun 2, 2016

I like it. And it doesn't look too material, which is cool.

Links to documentation is nice idea.

We need to return info badge to plugins.

There is only one UX issue right now: we don't show that plugins are inside opened file. Maybe we should make files aside like app left menu panel with full height from header to bottom of the page?

@andywer
Copy link
Owner

andywer commented Jun 2, 2016

Yeah, looks nice, yet not too materialish.

@Gaserd What's the difference between 'Documentation' & 'GitHub'? The only documentation right now is on github 😅
@ai What do you mean by "we don't show that plugins are inside opened file"?

@ai
Copy link
Author

ai commented Jun 2, 2016

@andywer I mean, that we don't show clicking on file will reload plugin sections. That plugins is a content of current file.

@Gaserd
Copy link
Contributor

Gaserd commented Jun 2, 2016

@ai @andywer Ok. I think about this

@Gaserd
Copy link
Contributor

Gaserd commented Jun 2, 2016

@andywer @ai
I make this.

1 - Under the heading "file" show plugins
2 - Under the heading "plugin" show small text about this plugins and click this text go to npm

2016-06-02 20 36 22

@andywer
Copy link
Owner

andywer commented Jun 2, 2016

@Gaserd Interesting, but I see two problems... First, the executed plugins will be the same for all files, so showing there should be no need to show them for every file separately.

Secondly, showing some description text for the plugin is way more complicated then just linking to it. Not impossible, but a lot of effort.

@Gaserd
Copy link
Contributor

Gaserd commented Jun 2, 2016

@andywer hm hm hm.

@Gaserd
Copy link
Contributor

Gaserd commented Jun 2, 2016

@andywer back (?) for link npm ? :)

But,user may be use different plugins for different files

@andywer
Copy link
Owner

andywer commented Jun 2, 2016

@Gaserd You run postcss on your files with using some set of plugins, but you cannot change the plugins array during execution, so in practice there cannot be different plugins for different files. At least I cannot see a way to accomplish that.

Problem with the description is that we would need to fetch the package.json (or the github landing page) of each plugin used to get the description. Creating the link was simple: https://www.npmjs.com/package/${pluginName}

@Gaserd
Copy link
Contributor

Gaserd commented Jun 2, 2016

@andywer Okay 👍

@ai
Copy link
Author

ai commented Jun 2, 2016

We could try to take plugin description by:

let pkg = require('PLUGIN/package.json')
pkg.description

@andywer
Copy link
Owner

andywer commented Jun 2, 2016

@ai I fear that's not going to work, since this would be resolved to path/to/postcss-debug/node_modules/PLUGIN/package.json...

@ai
Copy link
Author

ai commented Jun 2, 2016

@andywer you don’t need to resolve, npm will do it for you. require('plugin') works, so require('plugin/package.json') will work too.

@ai
Copy link
Author

ai commented Jun 2, 2016

@andywer if you don’t start path from ./ npm will automatically find directory. this is why you could write require('postcss/parse') too

@andywer
Copy link
Owner

andywer commented Jun 2, 2016

@ai I am speaking of how node resolves when requiring like require('foo/file.ext'). If you don't start with ./ it will look for foo/file.ext in path.join(__dirname, 'node_modules'). Since postcss-debugger source files are not in your project directory where you have your CSS files, it will not find the plugin.

Or am I missing something else?

@ai
Copy link
Author

ai commented Jun 2, 2016

@andywer node.js will look at ./node_modules, if it will not find file it will look then in ../node_modules, then in ../../node_modules/ and in all other dirs.

So it will find plugin in most of cases. Especially if plugin is in project package.json.

Also in npm@3 all modules are in flat node_modules.

@andywer
Copy link
Owner

andywer commented Jun 2, 2016

@ai Ahh, you know what? I think we had two different use cases in mind...
You were rather thinking of a locally installed postcss-debug used by code (I guess) and I was thinking of a globally installed postcss-debug used via CLI :)

@ai
Copy link
Author

ai commented Jun 2, 2016

@andywer global npm install is evil :)

@andywer
Copy link
Owner

andywer commented Jun 2, 2016

@ai Haha! Fair enough ;)

@Gaserd
Copy link
Contributor

Gaserd commented Jun 3, 2016

  • added link for plugin under headline plugin
  • added time for plugin
  • added time for file
  • added size file
  • added button fullscreen for code block
  • added full path for file
  • fix small padding and margin

2016-06-03 11 01 35

@Gaserd
Copy link
Contributor

Gaserd commented Jun 3, 2016

  • added DarkTheme
    2016-06-03 11 27 58

@andywer
Copy link
Owner

andywer commented Jun 3, 2016

Looks cool, but I think we should stick to one theme. Maybe open a twitter poll on which theme to use?

@Gaserd
Copy link
Contributor

Gaserd commented Jun 3, 2016

@andywer I think about switch theme. Pressed Ctrl+D and switched theme, but you can open twitter poll on which theme :)

@andywer
Copy link
Owner

andywer commented Jun 3, 2016

@Gaserd Sounds nice, but it's still a small debugging utility. Let's not over-engineer :)

@Gaserd
Copy link
Contributor

Gaserd commented Jun 3, 2016

@andywer it is now a small debugging utillity, tommorow it is a big project about it all speaking 👍

@Gaserd
Copy link
Contributor

Gaserd commented Jun 3, 2016

Start twitter poll about themes. This is will fun 👍

@andywer
Copy link
Owner

andywer commented Jun 10, 2016

@Gaserd Haha :'D

@Gaserd
Copy link
Contributor

Gaserd commented Jun 14, 2016

@ai @andywer I think we leave our current icon 👍 And in future we have make new icon for this plugin, because I dont have idea for icon

@andywer
Copy link
Owner

andywer commented Jun 14, 2016

@Gaserd Seems fair. But can we make it monochrome? ;)

PS: We can collect ideas here: #12

@Gaserd
Copy link
Contributor

Gaserd commented Jun 14, 2016

@andywer you could insert PostCSS logo in white color ?

@Gaserd
Copy link
Contributor

Gaserd commented Jun 17, 2016

@ai @andywer added small fix in mobile UI

2016-06-17 14 05 02
2016-06-17 14 05 19
2016-06-17 14 05 29

@ai
Copy link
Author

ai commented Jun 17, 2016

@Gaserd it is hard to understand that click on file block change plugin list. They looks like similar links. People will ask: “why nothing changed after I clicked on file block”

@Gaserd
Copy link
Contributor

Gaserd commented Jun 17, 2016

@ai Okay.
pokerface

@andywer
Copy link
Owner

andywer commented Jun 17, 2016

@Gaserd You are doing great work here! I wasn't sure if anyone really uses a debugging utility on their phone, but... It will be pretty cool for demoing!

We should put the inspector with some sample code in gh-pages so people can try it out without installing it and it will even be usable when they try it on their iPhone :)

@Gaserd
Copy link
Contributor

Gaserd commented Jun 17, 2016

@andywer Thanks and you are right!

@Gaserd
Copy link
Contributor

Gaserd commented Jun 30, 2016

@andywer are you life ?

@andywer
Copy link
Owner

andywer commented Jun 30, 2016

@Gaserd Hey! Sorry for the delay. On one hand I have have been very busy the past days, on the other hand I guess I planned too much for the next release.

Here is the current roadmap:

  1. Come up with postcss-debug webpack plugin (how to integrate with webpack #11)
  2. Use webpack for the inspector
  3. Use CSS modules and refactor styles (they have become really messy already)
  4. Use stylelint
  5. Put a sample installation on gh-pages

I should probably cut it down in favor of releasing soon.

@Gaserd
Copy link
Contributor

Gaserd commented Jul 1, 2016

@andywer Awesome! I can you help ?

@andywer
Copy link
Owner

andywer commented Jul 2, 2016

@Gaserd I wish I could share some work on this, but I think this kind of refactoring requires too much insight into the code.

@Gaserd
Copy link
Contributor

Gaserd commented Jul 4, 2016

@andywer okay :)

@andywer
Copy link
Owner

andywer commented Jul 4, 2016

@Gaserd I just recognized we still need a solution to prevent accidentally clicking the plugin documentation link when you want to expand a snapshot. This happens to me permanently when using the latest (not yet released) UI.

@Gaserd
Copy link
Contributor

Gaserd commented Jul 4, 2016

@Gaserd
Copy link
Contributor

Gaserd commented Jul 26, 2016

@andywer are you live ? :)

@andywer
Copy link
Owner

andywer commented Aug 1, 2016

Hey @Gaserd. Yes, I am, but I was on holidays last week ;)

There are currently still two issues left:

  • Usability: Plugin help link will now often be accidentally clicked (updated UI #10 (comment))
  • Styles: The CSS files have grown wild and are pretty much unmaintainable now. Not sure how to solve this without re-writing the stylesheets completely... :-/

Sorry for the long delay!

@Gaserd
Copy link
Contributor

Gaserd commented Aug 2, 2016

@andywer Ow!
Maybe I help you with CSS yet you write nice core code ?
Push (commit) master branch and go write nice code
:)

@andywer
Copy link
Owner

andywer commented Aug 3, 2016

@Gaserd Not sure if I got you right... Do you mean you can clean up the CSS? The problem is that I want to fix stuff before merging to master, since the master branch should always remain "clean(ish)".

And... we still have to come up with a solution for

Usability: Plugin help link will now often be accidentally clicked (#10 (comment))

Because that will annoy users a lot, I think.

@Gaserd
Copy link
Contributor

Gaserd commented Aug 3, 2016

@andywer Yeah, I sure can clean CSS.
I think about this problem:

Plugin help link will now often be accidentally clicked (#10 (comment))

I start today clean CSS in develop branch.

@Gaserd
Copy link
Contributor

Gaserd commented Aug 7, 2016

@ai @andywer

Plugin help link will now often be accidentally clicked (#10 (comment))

I think we can make so

2016-08-07 12 11 46

@ai
Copy link
Author

ai commented Aug 7, 2016

Looks good 😊

@ai ai closed this as completed Aug 7, 2016
@ai ai reopened this Aug 7, 2016
@andywer
Copy link
Owner

andywer commented Aug 7, 2016

@Gaserd Yeah, I like it to :)

@Gaserd
Copy link
Contributor

Gaserd commented Aug 18, 2016

@ai @andywer Yeah! Congrats!

@andywer
Copy link
Owner

andywer commented Aug 18, 2016

Just published version 0.4.0 with the updated UI. Will close this issue ☀️

@andywer andywer closed this as completed Aug 18, 2016
@andywer
Copy link
Owner

andywer commented Aug 18, 2016

Thanks @Gaserd!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants