-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory-leaks #34
Comments
I already fixed the issue in |
Hey - looking into it now. Please understand that I don't get to everything immediately. |
I've reproduced the issue and confirmed that your fix works. Thanks, nice catch! I also took the liberty of creating a PR with from your fork, here: angular-redux/store#409. There are a couple of minor cleanup items after which I'd be happy to merge it. |
I cleaned up the PR and merged it. The fix has been released in |
I changed two lines in your example and run it. After about 30,000 actions app accumulates up to 300MB memory and crashes.
These are steps to reproduce this issue:
addTicket
inanimal
component to, this code simulates dispatching many actions to observe the issue easier:createLogger
anddevTools enhancer
fromstore/module
:yarn start
+
to start the process: this will dispatch 10000 actions and update the UI.You may check the memory in
Chrome devTools
too.The text was updated successfully, but these errors were encountered: