Compile Error with TypeScript 2.4.1

[kiwikern]

This is a...

• feature request
• bug report
• usage question

What toolchain are you using for transpilation/bundling?

• @angular/cli
• Custom @ngTools/webpack
• Raw ngc
• SystemJS
• Rollup
• Other

Environment

NodeJS Version: 6.10.3
Typescript Version: 2.4.1
Angular Version: 4.2.5
@angular-redux/store version: 6.5.4
@angular/cli version: 1.1.2
OS: Windows 10

Actual Behaviour:

After updating typescript to 2.4.1, I got a compile error for MockObservableStore. I could resolve this by adding "skipLibCheck": true to my tsconfig.json (just a workaround though)
Seems to be similar to angular/angular#17800

Stack Trace/Error Message:

ERROR in D:/workspace/superfitschedule/node_modules/@angular-redux/store/lib/testing/observable-store.mock.d.ts (21,22): Class 'MockObservableStore<State>' incorrectly implements interface 'ObservableStore<any>'.
  Types of property 'configureSubStore' are incompatible.
    Type '<SubState>(basePath: (string | number)[], localReducer: Reducer<SubState>) => MockObservableStore...' is not assignable to type '<SubState>(basePath: (string | number)[], localReducer: Reducer<SubState>) => ObservableStore<Sub.
..'.
      Type 'MockObservableStore<SubState>' is not assignable to type 'ObservableStore<SubState>'.
        Types of property 'configureSubStore' are incompatible.
          Type '<SubState>(basePath: (string | number)[], localReducer: Reducer<SubState>) => MockObservableStore...' is not assignable to type '<SubState>(basePath: (string | number)[], localReducer: Reducer<SubState>) => ObservableStor
e<Sub...'.
            Type 'MockObservableStore<SubState>' is not assignable to type 'ObservableStore<SubState>'.
              Types of property 'configureSubStore' are incompatible.
                Type '<SubState>(basePath: (string | number)[], localReducer: Reducer<SubState>) => MockObservableStore...' is not assignable to type '<SubState>(basePath: (string | number)[], localReducer: Reducer<SubState>) => Observab
leStore<Sub...'.
                  Type 'MockObservableStore<SubState>' is not assignable to type 'ObservableStore<SubState>'.
                    Types of property 'dispatch' are incompatible.
                      Type '(action: Action) => Action' is not assignable to type 'Dispatch<SubState>'.
                        Type 'Action' is not assignable to type 'A'.

[SethDavenport]

I'll take a look on saturday

[BendingBender]

There is also an error in ./node_modules/@angular-redux/store/lib/testing/ng-redux.mock.d.ts:12:22:

    TS2415: Class 'MockNgRedux' incorrectly extends base class 'NgRedux<any>'.
  Types of property 'configureSubStore' are incompatible.
    Type '<SubState>(basePath: (string | number)[], localReducer: Reducer<SubState>) => MockObservableStore...' is not assignable to type '<SubState>(basePath: (string | number)[], localReducer: Reducer<SubState>) => ObservableStore<Sub...'.
      Type 'MockObservableStore<SubState>' is not assignable to type 'ObservableStore<SubState>'.
        Types of property 'configureSubStore' are incompatible.
          Type '<SubState>(basePath: (string | number)[], localReducer: Reducer<SubState>) => MockObservableStore...' is not assignable to type '<SubState>(basePath: (string | number)[], localReducer: Reducer<SubState>) => ObservableStore<Sub...'.
            Type 'MockObservableStore<SubState>' is not assignable to type 'ObservableStore<SubState>'.
              Types of property 'configureSubStore' are incompatible.
                Type '<SubState>(basePath: (string | number)[], localReducer: Reducer<SubState>) => MockObservableStore...' is not assignable to type '<SubState>(basePath: (string | number)[], localReducer: Reducer<SubState>) => ObservableStore<Sub...'.
                  Type 'MockObservableStore<SubState>' is not assignable to type 'ObservableStore<SubState>'.
                    Types of property 'configureSubStore' are incompatible.
                      Type '<SubState>(basePath: (string | number)[], localReducer: Reducer<SubState>) => MockObservableStore...' is not assignable to type '<SubState>(basePath: (string | number)[], localReducer: Reducer<SubState>) => ObservableStore<Sub...'.
                        Type 'MockObservableStore<SubState>' is not assignable to type 'ObservableStore<SubState>'.
                          Types of property 'dispatch' are incompatible.
                            Type '(action: Action) => Action' is not assignable to type 'Dispatch<SubState>'.
                              Type 'Action' is not assignable to type 'A'.

[SethDavenport]

Give @angular-redux/[email protected] a try.

[SethDavenport]

Also note that I have a fix to make to @angular-redux/router as well, if you're using that. I'll take care of that tomorrow (see angular-redux/router#17).

[kiwikern]

Works for me. Thanks for the quick fix! 🙂 👍

[SethDavenport]

Great!

[banderberg]

I get this same error with TypeScript 2.5.3 using @angular-redux/store 6.5.7.