History traversal can still occur while modal is up

[ngoyal]

This may be related to #738.

In v 0.11.0 when a modal is up, I am able to have the background page go back a route via keyboard shortcuts (on mac in chrome it is cmd + left arrow). I think history traversal should be prevented in this case if the action ends up being a route within the same SPA.

I should note that I am using angular-ui-router for state routing.

[pkozlowski-opensource]

@ngoyal we don't have any built-in handling of the location / route change and this is by design. The reason for this is that I've heard people asking one of 2 different behaviours (there are probably other use-cases as well):

• prevent location / route change when a modal is open
• close all the open modals when location / route change occurs

As you can see those are 2 contradicting requirements and we don't want to do arbitrary choices in this library.

The good news is that you can easily handle it in your application code using the built-in modalStack service. For example, to prevent route change you could write (warning! non-tested code!):

angular.module('myApp', []).run(function($rootScope, $modalStack){
    $rootScope.on('$locationChangeStart', function(evt) {
      if ($modalStack.top()) {
        evt.preventDefault();
      } 
   });
});   

Would it work for you?

[ngoyal]

Absolutely that would work. I appreciate the suggested fix and quick response.

[ngoyal]

Quick copy/paste fix on the example for those who see this:

angular.module('myApp', []).run(function($rootScope, $modalStack){
    $rootScope.$on('$locationChangeStart', function(evt) {
      if ($modalStack.getTop()) {
        evt.preventDefault();
      } 
   });
});