Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Dialog: allow merging of css classes between global options and instance options #294

Closed
rewritten opened this issue Apr 4, 2013 · 2 comments

Comments

@rewritten
Copy link

When an application has global styles defined, the natural thing would be to configure some class through the provider, like (sorry for the CoffeeScript code, I can't write plain JS anymore....)

myModule.config ["$dialogProvider", ($dialogProvider) ->
  $dialogProvider.options
    modalClass: "some-global-class"
]

But then an instance of Dialog can't add another class, it must specify the whole list of classes:

$dialog.dialog
  modalClass: "some-global-class specific-class"
.open()

Thus, it's a burden to track everywhere the global dialog class. If one could have something like

$dialog.dialog
  modalAdditionalClass: "specific-class"
.open()

this could be added to the globally configured one.

@skytracer
Copy link

+1

Especially useful for different messageBox type, eg "errorBox", "confirmBox" etc

@pkozlowski-opensource
Copy link
Member

It will be handled in #441

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants