Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

bug(modal) Modal 1 on route 1 won't show if modal 2 on route 2 has scope passed to it. #935

Closed
Narretz opened this issue Sep 3, 2013 · 1 comment
Milestone

Comments

@Narretz
Copy link
Contributor

Narretz commented Sep 3, 2013

edit: turns out this can be trivially fixed with using

modalOptions = angular.extend(angular.copy(defaultOptions), modalOptions);

instead of

 modalOptions = angular.extend(defaultOptions, modalOptions);

http://plnkr.co/edit/XZKiM0?p=preview

Preparation:

  1. Make two routes
  2. On both routes, open a modal (different templates and controllers)
  3. in route 2, pass route scope to modal.

Steps:

  1. route 1, open modal, close it (works)
  2. go to route 2, open modal, close it (works)
  3. Go back to route 1, open modal (backdrop shows, modal is created, but the animation never finishes)
  4. Go back to route 2, open modal (works)

Notes:
it does not happen when both modals are on the same route
passing scope : null also prevents the bug from occuring

@pkozlowski-opensource
Copy link
Member

@Narretz awesome, thnx for spotting this one. I must say that the community around this project is fantastic, thnx guys for looking into those early "drafts"!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants