Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commas and semicolons counted as branches in code coverage #6600

Closed
MarcBanc opened this issue Jun 7, 2017 · 5 comments
Closed

Commas and semicolons counted as branches in code coverage #6600

MarcBanc opened this issue Jun 7, 2017 · 5 comments
Assignees
Labels
needs: investigation Requires some digging to determine if action is needed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@MarcBanc
Copy link

MarcBanc commented Jun 7, 2017

Bug Report or Feature Request (mark with an x)

- [ x ] bug report -> please search issues before submitting
- [ ] feature request

Versions.

@angular/cli: 1.1.0
node: 7.2.1
os: win32 ia32
@angular/animations: 4.1.3
@angular/cli: 1.1.0
@angular/common: 4.1.3
@angular/compiler: 4.1.3
@angular/compiler-cli: 4.1.3
@angular/core: 4.1.3
@angular/forms: 4.1.3
@angular/http: 4.1.3
@angular/platform-browser: 4.1.3
@angular/platform-browser-dynamic: 4.1.3
@angular/router: 4.1.3

Repro steps.

ng test --code-coverage

The log given by the failure.

image

image

Desired functionality.

commas and semicolons should not be counted as branches

Mention any other details that might be useful.

@filipesilva filipesilva added needs: investigation Requires some digging to determine if action is needed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Jun 7, 2017
@filipesilva
Copy link
Contributor

The code coverage pipeline has a bunch of moving parts (webpack loader, karma plugin, instanbul proper). This might be a problem in any of those. Needs investigation.

@MarcBanc
Copy link
Author

MarcBanc commented Jun 7, 2017

How can i help?

@whyboris
Copy link

whyboris commented Jun 7, 2017

Can confirm the problem within my project in very many files despite 100% test coverage. For example after @Input() declarations and within the constructor after private declarations.

@sumitarora
Copy link
Contributor

Duplicate of: #5871

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: investigation Requires some digging to determine if action is needed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

No branches or pull requests

4 participants