fix(language-service): tolerate errors in decorators #14634
Conversation
| @@ -35,7 +35,7 @@ export class CompilerHost implements AotCompilerHost { | |||
|
|
|||
| constructor( | |||
| protected program: ts.Program, protected options: AngularCompilerOptions, | |||
| protected context: CompilerHostContext) { | |||
| protected context: CompilerHostContext, collectorOptions?: CollectorOptions) { | |||
There was a problem hiding this comment.
this seems to be unused?
| @@ -335,7 +343,8 @@ export class StaticReflector implements ReflectorReader { | |||
| if (value && (depth != 0 || value.__symbolic != 'error')) { | |||
| const parameters: string[] = targetFunction['parameters']; | |||
| const defaults: any[] = targetFunction.defaults; | |||
| args = args.map(arg => simplifyInContext(context, arg, depth + 1)); | |||
| args = args.map(arg => simplifyInContext(context, arg, depth + 1)) | |||
| .map(arg => shouldIgnore(arg) ? undefined : arg); | |||
There was a problem hiding this comment.
could it be filter() instead? where do the undefined values go?
There was a problem hiding this comment.
No as that would change the argument order. Imagine the call a(1, () => {}, 2), I want the transformed into a(1, undefined, 2) not a(1,2).
| @@ -18,6 +18,14 @@ const ANGULAR_CORE = '@angular/core'; | |||
|
|
|||
| const HIDDEN_KEY = /^\$.*\$$/; | |||
|
|
|||
| const ignore = { | |||
| @@ -529,7 +538,8 @@ export class StaticReflector implements ReflectorReader { | |||
| let converter = self.conversionMap.get(staticSymbol); | |||
| if (converter) { | |||
| const args = | |||
| argExpressions.map(arg => simplifyInContext(context, arg, depth + 1)); | |||
| argExpressions.map(arg => simplifyInContext(context, arg, depth + 1)) | |||
| .map(arg => shouldIgnore(arg) ? undefined : arg); | |||
|
|
||
| } | ||
| `; | ||
| init(data, [], () => {}, {verboseInvalidExpression: true}); |
There was a problem hiding this comment.
should there be a test for what happens with a Component with errors and verboseInvalidExpression is false?
There was a problem hiding this comment.
Not in this case. There are tests elsewhere that test that. The only time we need to handle more than one error is the case where there is error reporter and verboseInvalidExpressions is true. Testing this with verboseInvalidExpression as false would simplify the expression to a single error node which is what the other tests are already testing.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #14631
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
Metadata errors caused the language service to produce strange cascading errors causing problems such as reported here: angular/vscode-ng-language-service#10
What is the new behavior?
Metadata errors are reported and ignored.
Does this PR introduce a breaking change? (check one with "x")