From 2a2d8378c0365828e83f927f7361bd2ee4d1dc28 Mon Sep 17 00:00:00 2001 From: Paul Gschwendtner Date: Wed, 11 Dec 2019 21:22:57 +0100 Subject: [PATCH] fix: google-maps and youtube-player package missing tslib dependency (#17939) * build: use placeholder for tslib version * fix: google-maps and youtube-player package missing tslib dependency The google-maps and youtube-player package currently do not have `tslib` listed as dependency while TypeScript helper's are enabled and used in these packages. --- packages.bzl | 3 +++ src/cdk-experimental/package.json | 2 +- src/cdk/package.json | 2 +- src/google-maps/package.json | 3 ++- src/material-experimental/package.json | 2 +- src/material-moment-adapter/package.json | 2 +- src/material/package.json | 2 +- src/youtube-player/package.json | 3 ++- 8 files changed, 12 insertions(+), 7 deletions(-) diff --git a/packages.bzl b/packages.bzl index c5b1a91c94ce..4757d2b56627 100644 --- a/packages.bzl +++ b/packages.bzl @@ -3,9 +3,12 @@ # version for the placeholders. ANGULAR_PACKAGE_VERSION = "^9.0.0-0 || ^10.0.0-0" MDC_PACKAGE_VERSION = "^4.0.0" +TSLIB_PACKAGE_VERSION = "^1.9.0" + VERSION_PLACEHOLDER_REPLACEMENTS = { "0.0.0-MDC": MDC_PACKAGE_VERSION, "0.0.0-NG": ANGULAR_PACKAGE_VERSION, + "0.0.0-TSLIB": TSLIB_PACKAGE_VERSION, } # List of default Angular library UMD bundles which are not processed by ngcc. diff --git a/src/cdk-experimental/package.json b/src/cdk-experimental/package.json index 828011d7c83f..a27a6b474aa6 100644 --- a/src/cdk-experimental/package.json +++ b/src/cdk-experimental/package.json @@ -22,7 +22,7 @@ "peerDependencies": { "@angular/cdk": "0.0.0-PLACEHOLDER", "@angular/core": "0.0.0-NG", - "tslib": "^1.9.0" + "tslib": "0.0.0-TSLIB" }, "sideEffects": false, "publishConfig":{ diff --git a/src/cdk/package.json b/src/cdk/package.json index 494332e0cfc7..c42f40ecd505 100644 --- a/src/cdk/package.json +++ b/src/cdk/package.json @@ -29,7 +29,7 @@ "peerDependencies": { "@angular/core": "0.0.0-NG", "@angular/common": "0.0.0-NG", - "tslib": "^1.9.0" + "tslib": "0.0.0-TSLIB" }, "optionalDependencies": { "parse5": "^5.0.0" diff --git a/src/google-maps/package.json b/src/google-maps/package.json index 1f6bb0ae77b3..a6e044c71ddd 100644 --- a/src/google-maps/package.json +++ b/src/google-maps/package.json @@ -25,7 +25,8 @@ }, "homepage": "https://github.com/angular/components/tree/master/src/google-maps#readme", "dependencies": { - "@types/googlemaps": "^3.37.0" + "@types/googlemaps": "^3.37.0", + "tslib": "0.0.0-TSLIB" }, "peerDependencies": { "@angular/core": "0.0.0-NG", diff --git a/src/material-experimental/package.json b/src/material-experimental/package.json index cab7ade227b6..90f992bf38d2 100644 --- a/src/material-experimental/package.json +++ b/src/material-experimental/package.json @@ -23,7 +23,7 @@ "@angular/core": "0.0.0-NG", "@angular/material": "0.0.0-PLACEHOLDER", "material-components-web": "0.0.0-MDC", - "tslib": "^1.9.0" + "tslib": "0.0.0-TSLIB" }, "sideEffects": false, "publishConfig":{ diff --git a/src/material-moment-adapter/package.json b/src/material-moment-adapter/package.json index 85f90d71e6cd..a2215bedd378 100644 --- a/src/material-moment-adapter/package.json +++ b/src/material-moment-adapter/package.json @@ -23,7 +23,7 @@ "@angular/material": "0.0.0-PLACEHOLDER", "@angular/core": "0.0.0-NG", "moment": "^2.18.1", - "tslib": "^1.9.0" + "tslib": "0.0.0-TSLIB" }, "ng-update": { "packageGroup": [ diff --git a/src/material/package.json b/src/material/package.json index a6df8967e040..b959a9b798dc 100644 --- a/src/material/package.json +++ b/src/material/package.json @@ -31,7 +31,7 @@ "@angular/core": "0.0.0-NG", "@angular/common": "0.0.0-NG", "@angular/forms": "0.0.0-NG", - "tslib": "^1.9.0" + "tslib": "0.0.0-TSLIB" }, "schematics": "./schematics/collection.json", "ng-update": { diff --git a/src/youtube-player/package.json b/src/youtube-player/package.json index 0c33d1066b61..e166c014f6a7 100644 --- a/src/youtube-player/package.json +++ b/src/youtube-player/package.json @@ -25,7 +25,8 @@ }, "homepage": "https://github.com/angular/components/tree/master/src/youtube-player#readme", "dependencies": { - "@types/youtube": "^0.0.38" + "@types/youtube": "^0.0.38", + "tslib": "0.0.0-TSLIB" }, "peerDependencies": { "@angular/core": "0.0.0-NG",