Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material Schematics missing external dependency #11341

Closed
cgatian opened this issue May 15, 2018 · 3 comments · Fixed by #11647
Closed

Material Schematics missing external dependency #11341

cgatian opened this issue May 15, 2018 · 3 comments · Fixed by #11647
Assignees
Labels
needs: discussion Further discussion with the team is needed before proceeding

Comments

@cgatian
Copy link

cgatian commented May 15, 2018

Bug, feature request, or proposal:

parse5 is used within schematics/utils/html.ts but is never listed as a dependency in package.json. This prevents being able to extending the material schematics without library developers adding this dependency.

What is the expected behavior?

parse5 should be listed as a dependency of material schematics.

What is the current behavior?

import/require statement fails when material schematic collection is used with externalSchematic

externalSchematic('@angular/material', 'material-shell', {}),  // Errors

What are the steps to reproduce?

Clone this repository and follow README

What is the use-case or motivation for changing an existing behavior?

Developers wishing to extend the existing Material schematics need to include parse5 as a dependency.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

6.0+

@amcdnl
Copy link
Contributor

amcdnl commented May 20, 2018

@jelbourn - I don't see this anywhere in the packages? How is this even working LOL?

@jelbourn
Copy link
Member

@amcdnl most people probably have it installed incidentally due to some other package (maybe CLI)

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
@mmalerba mmalerba added the needs: discussion Further discussion with the team is needed before proceeding label Mar 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: discussion Further discussion with the team is needed before proceeding
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants