Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu position going wrong on Scroll. Reappearance of #11365 #12937

Closed
Stexxen opened this issue Sep 1, 2018 · 8 comments
Closed

Menu position going wrong on Scroll. Reappearance of #11365 #12937

Stexxen opened this issue Sep 1, 2018 · 8 comments

Comments

@Stexxen
Copy link

Stexxen commented Sep 1, 2018

Bug, feature request, or proposal:

Bug, Reappearance of #11365

What is the expected behavior?

Menu should not move

What is the current behavior?

It scrolls down and potentially changes shape.

What are the steps to reproduce?

https://stackblitz.com/edit/angular-oy329b-n7au1b
Forked from Angular Docs

Click 'Animal Index' While menu is open scroll window.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Material 6.4.7,
Angular 6.1.6

Tested on
Chrome 68, 71
Firefox 52, 61
Safari 11, 12
Opera 55
all on MacOS 10.13

image

@crisbeto
Copy link
Member

crisbeto commented Sep 1, 2018

I'm not getting this on the demo app running against master. Maybe the fix didn't get released? cc @jelbourn

@Stexxen
Copy link
Author

Stexxen commented Sep 1, 2018

You could be right, I assumed that as the merge was prior to the release of 6.4.7 It would've been included. But now i'm not so sure....

@Stexxen
Copy link
Author

Stexxen commented Sep 1, 2018

Have confirmed. Your fix is included in 7 Beta.0 but not in 6.4.7.
Am closing, sorry for the confusion.

@Stexxen Stexxen closed this as completed Sep 1, 2018
@gpessa
Copy link

gpessa commented Sep 14, 2018

This is still there in 6.4.7

@crisbeto
Copy link
Member

This is fixed in 7.0.0.

@gpessa
Copy link

gpessa commented Sep 14, 2018

7 is a beta and maybe we cant update to it

@Stexxen
Copy link
Author

Stexxen commented Sep 14, 2018

@gpessa The particular fix that @crisbeto submitted has not been cherrypicked back to the 6.4.x branch. So I think it unlikely that 6.4.8 will have it either.

I don't know why this is; it may rely on other patches that cannot be back-ported.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants