Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

form-field(select): update styling to match current version of the spec #14171

Open
VamsiDharmaji opened this issue Nov 16, 2018 · 3 comments
Open
Labels
area: material/form-field area: material/select material spec Issue related to the Material Design spec https://material.io/design/ P4 A relatively minor issue that is not relevant to core functions

Comments

@VamsiDharmaji
Copy link

Bug, feature request, or proposal:

Bug

Mat-Select : Dropdown arrow is not vertically centered in the outline styled .

What is the expected behavior?

Dropdown arrow is should be vertically centered in the outline styled .

What is the current behavior?

Dropdown arrow is not vertically centered in the outline styled .

Notice that in contrast filled style has thin ( 1px ) border
image

What are the steps to reproduce?

Providing a StackBlitz reproduction is the best way to share your issue.

URL: https://stackblitz.com/edit/angular-jei8z9?file=app%2Fselect-overview-example.html

What is the use-case or motivation for changing an existing behavior?

UX

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular and Material 7+

Is there anything else we should know?

I am more than happy to help fix this issue, please let me know if can create a pull request

@josephperrott josephperrott added the P4 A relatively minor issue that is not relevant to core functions label Nov 20, 2018
@mmalerba
Copy link
Contributor

mmalerba commented Dec 3, 2018

I recommend using a label rather than a placeholder: https://stackblitz.com/edit/angular-jei8z9-csd356?file=app/select-overview-example.html

The label will appear aligned with the arrow, while the placeholder will appear in the same place that the value would

@mmalerba mmalerba closed this as completed Dec 3, 2018
@VamsiDharmaji
Copy link
Author

@mmalerba We have both label and placeholder texts. Cannot use placeholder text as label.

@mmalerba mmalerba reopened this Dec 12, 2018
@mmalerba mmalerba changed the title Mat-Select : Dropdown is not vertically centered in the outline styled form-field: update styling to match current version of the spec Dec 12, 2018
@mmalerba
Copy link
Contributor

In an older version of the spec the value was intentionally not centered (similar to the way it is for the filled version of the form-field in the spec today). The spec has since changed, so we will need to update the styles to center the text

@Splaktar Splaktar changed the title form-field: update styling to match current version of the spec form-field(select): update styling to match current version of the spec Jan 6, 2020
@Splaktar Splaktar added the material spec Issue related to the Material Design spec https://material.io/design/ label Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: material/form-field area: material/select material spec Issue related to the Material Design spec https://material.io/design/ P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Development

No branches or pull requests

5 participants