Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MatButton with MatRipple works wrong in Safari 12. #15445

Closed
mokeev1995 opened this issue Mar 12, 2019 · 5 comments
Closed

MatButton with MatRipple works wrong in Safari 12. #15445

mokeev1995 opened this issue Mar 12, 2019 · 5 comments
Assignees
Labels
area: material/button P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@mokeev1995
Copy link

mokeev1995 commented Mar 12, 2019

Button ripples works wrong in Safari. Ripples does not respect border-radius.

What is the expected behavior?

Ripples respects border-radius applied to button.

What is the current behavior?

Just hovered button:
Screen Shot 2019-03-12 at 12 53 16

Pressed button with ripples:
Screen Shot 2019-03-12 at 12 53 33

What are the steps to reproduce?

Place mat-button anywhere and press the button.

https://stackblitz.com/edit/angular-material2-issue-auuj1u

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

macOS Sierra 10.12.6
Safari 12
typescript: 3.2.2
@angular/animations: 7.2.8
@angular/cdk: 7.3.3
@angular/common: 7.2.8
@angular/compiler: 7.2.8
@angular/core: 7.2.8
@angular/material: 7.3.3

@mokeev1995 mokeev1995 changed the title MatButton MatRipple Safari MatButton with MatRipple works wrong in Safari 12. Mar 12, 2019
@mokeev1995
Copy link
Author

mokeev1995 commented Mar 12, 2019

Looks like bug #9416 (fixed in #9424) came back.

@crisbeto
Copy link
Member

See #12311.

@mokeev1995
Copy link
Author

mokeev1995 commented Mar 12, 2019

@crisbeto thanks

@ristarr11
Copy link

ristarr11 commented Jun 28, 2019

Hello, I had similar issue with MDC Web, and this helped:
.mdc-button {
..
will-change: transform, opacity;
}

Not sure if this gonna break something else, though..

@mmalerba mmalerba added the needs triage This issue needs to be triaged by the team label May 20, 2020
@crisbeto crisbeto self-assigned this May 25, 2020
@crisbeto crisbeto added area: material/button P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed needs triage This issue needs to be triaged by the team labels May 25, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: material/button P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

No branches or pull requests

5 participants