cdkConnectedOverlay should let us change positioning strategy

[mertdeg2]

The problem is that this directive is not flexible enough to pass in arbitrary positioning strategy.

[crisbeto]

Doesn't this somewhat defeat the purpose of the directive? If you're already creating the strategy, the rest of the overlay only needs a few more lines of code.

[mertdeg2]

We have an internal component that is built on top of this directive.

We use all of the other features. But the positioning strategy is not overridable. It mostly looks like below:

<ng-template
  cdkConnectedOverlay
  [cdkConnectedOverlayHasBackdrop]="hasBackdrop"
  [cdkConnectedOverlayBackdropClass]="getBackdropClasses()"
  [cdkConnectedOverlayOrigin]="trigger"
  [cdkConnectedOverlayPositionStrategy]="positionStrategy"
  [cdkConnectedOverlayOpen]="isOpen"
  [cdkConnectedOverlayPositions]="positions"
  [cdkConnectedOverlayMinWidth]="minWidth"
  [cdkConnectedOverlayViewportMargin]="overlayViewportMargin"
  [cdkConnectedOverlayGrowAfterOpen]="true"
  [cdkConnectedOverlayPush]="true"
  (backdropClick)="close()"
  (detach)="close()">

[crisbeto]

Leaving up to @jelbourn on how to proceed here, but it'll definitely need some unit tests.

[jelbourn]

We talked about it ahead of time; I'm okay with this change, though it does need a unit test :)

[mertdeg2]

Added a unit test for this.

[jelbourn]

@mertdeg2 overall looks good but there are some failures on CI

[mertdeg2]

I think i fixed the failures on CI

[jelbourn]

LGTM

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}