Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(snack-bar): too tall under some circumstances in Safari #16679

Merged
merged 1 commit into from
Aug 27, 2019
Merged

fix(snack-bar): too tall under some circumstances in Safari #16679

merged 1 commit into from
Aug 27, 2019

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 4, 2019

Fixes the snack bar stretching to 100% of the viewport height in some cases in Safari.

Fixes #16605.

@crisbeto
fix(snack-bar): too tall under some circumstances in Safari
1c81b5b 
Fixes the snack bar stretching to 100% of the viewport height in some cases in Safari.

Fixes angular#16605.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Aug 4, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 4, 2019
@crisbeto crisbeto added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Aug 4, 2019
@crisbeto
Copy link
Member Author

crisbeto commented Aug 4, 2019

Caretaker note: it might be worth keeping an eye on the screenshot tests for this one. It seems like I introduced the height: 100% here #12634, but I don't remember why it's there. From my testing, removing it doesn't make much of a difference, but I might be missing some case.

jelbourn
jelbourn approved these changes Aug 21, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 21, 2019
@jelbourn jelbourn merged commit e9baa09 into angular:master Aug 27, 2019
mmalerba pushed a commit to mmalerba/components that referenced this pull request Aug 27, 2019
@crisbeto @mmalerba
fix(snack-bar): too tall under some circumstances in Safari (angular#…
377d2e9 
…16679)

Fixes the snack bar stretching to 100% of the viewport height in some cases in Safari.

Fixes angular#16605.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@josephperrott josephperrott Awaiting requested review from josephperrott

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Snackbar fills whole screen on deploy
3 participants
@crisbeto @jelbourn @googlebot