Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(icon): Use the ErrorLogger to log HTTP errors #16855

Merged
merged 1 commit into from
Aug 23, 2019
Merged

fix(icon): Use the ErrorLogger to log HTTP errors #16855

merged 1 commit into from
Aug 23, 2019

Conversation

jermowery
Copy link
Contributor

This makes it easier for users of MatIconRegistry to diagnose issues with loading SVG icon sets. Previously no information was available when HTTP requests failed and a console log would be generated which is bad form in prod

@jermowery jermowery requested a review from jelbourn as a code owner August 23, 2019 17:13
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 23, 2019
jelbourn
jelbourn approved these changes Aug 23, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Aug 23, 2019
crisbeto
crisbeto reviewed Aug 23, 2019
View reviewed changes
@jermowery
fix(icon): Use the ErrorLogger to log HTTP errors
0f9e950 
Update API

Update API Goldens and incorporate feedback

Fix merge conflicts

Fix auto style fix

Add breaking change documentation
crisbeto
crisbeto approved these changes Aug 23, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 75686e8 into angular:master Aug 23, 2019
mmalerba pushed a commit to mmalerba/components that referenced this pull request Aug 27, 2019
@jermowery @mmalerba
fix(icon): use ErrorLogger to log http errors (angular#16855)
8c43d8f
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jermowery @jelbourn @crisbeto @googlebot