Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chips): preselected chip not highlighted on init inside OnPush component #16868

Merged
merged 1 commit into from
Sep 6, 2019
Merged

fix(chips): preselected chip not highlighted on init inside OnPush component #16868

merged 1 commit into from
Sep 6, 2019

Conversation

crisbeto
Copy link
Member

Fixes preselected chips not getting the mat-chip-selected class on init if they're inside an OnPush component.

Fixes #16841.

@crisbeto
fix(chips): preselected chip not highlighted on init inside OnPush co…
347b484 
…mponent

Fixes preselected chips not getting the `mat-chip-selected` class on init if they're inside an OnPush component.

Fixes angular#16841.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Aug 24, 2019
@crisbeto crisbeto requested a review from jelbourn as a code owner August 24, 2019 06:41
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 24, 2019
jelbourn
jelbourn approved these changes Sep 5, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 5, 2019
@jelbourn jelbourn merged commit aad7ff7 into angular:master Sep 6, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chips: highlight not working when ChangeDetectionStrategy.OnPush
3 participants
@crisbeto @jelbourn @googlebot