-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Dialog): don't override type attribute if set on mat-dialog-close #16927
Conversation
only default the type attribute on mat-dialog-close if it isn't set angular#16909
Can you update the API gold? Just run
(we have golds for d.ts files to prevent public APIs from being changed inadvertently) |
Done |
The failing tests don't look to be related to the dialog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
only default the type attribute on mat-dialog-close if it isn't set
#16909