Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Dialog): don't override type attribute if set on mat-dialog-close #16927

Merged
merged 2 commits into from
Sep 9, 2019

Conversation

flauc
Copy link
Contributor

@flauc flauc commented Aug 30, 2019

only default the type attribute on mat-dialog-close if it isn't set

#16909

only default the type attribute on mat-dialog-close if it isn't set

angular#16909
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 30, 2019
@jelbourn
Copy link
Member

Can you update the API gold? Just run

yarn bazel run //tools/public_api_guard:material/dialog.d.ts_api.accept

(we have golds for d.ts files to prevent public APIs from being changed inadvertently)

@jelbourn jelbourn added the target: minor This PR is targeted for the next minor release label Aug 30, 2019
@flauc
Copy link
Contributor Author

flauc commented Aug 31, 2019

yarn bazel run //tools/public_api_guard:material/dialog.d.ts_api.accept

Done

@flauc
Copy link
Contributor Author

flauc commented Aug 31, 2019

The failing tests don't look to be related to the dialog.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 4, 2019
@ngbot
Copy link

ngbot bot commented Sep 4, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: tests_browserstack" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jelbourn jelbourn merged commit 3ee3ecb into angular:master Sep 9, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants