Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(icon): Use the ErrorLogger to log MatIcon SVG errors #16967

Merged
merged 1 commit into from
Sep 4, 2019
Merged

fix(icon): Use the ErrorLogger to log MatIcon SVG errors #16967

merged 1 commit into from
Sep 4, 2019

Conversation

jermowery
Copy link
Contributor

Currently a console.log is used. This change switches to using
ErrorHandler.
ErrorHandler is better because it allows the user of MatIcon to define
how Errors should be handled instead of relying on the console.

@jermowery
Use the ErrorHandler to log errors in MatIcon.
3862337 
Currently a console.log is used. This change switches to using
ErrorHandler.
ErrorHandler is better because it allows the user of MatIcon to define
how Errors should be handled instead of relying on the console.

Update API goldens
@jermowery jermowery requested a review from jelbourn as a code owner September 3, 2019 21:41
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 3, 2019
@jermowery
Copy link
Contributor Author

Errors in CI are not related to this change

jelbourn
jelbourn approved these changes Sep 3, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Sep 3, 2019
@ngbot
Copy link

ngbot bot commented Sep 3, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: tests_browserstack" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jelbourn jelbourn added the G This is is related to a Google internal issue label Sep 4, 2019
@jelbourn jelbourn merged commit dccddd9 into angular:master Sep 4, 2019
jelbourn added a commit to jelbourn/components that referenced this pull request Sep 5, 2019
@jelbourn
Revert "fix(icon): use ErrorHandler to log MatIcon errors (angular#16967
11d20a5 
)"

This reverts commit dccddd9.

Temporarily reverting because this causes a failure in a Google Cloud
test that didn't show up on the presubmit. Will undo this revert once we
can resolve that failure.
jelbourn added a commit that referenced this pull request Sep 5, 2019
@jelbourn
Revert "fix(icon): use ErrorHandler to log MatIcon errors (#16967)" (#…
680ed00 
…16987)

This reverts commit dccddd9.

Temporarily reverting because this causes a failure in a Google Cloud
test that didn't show up on the presubmit. Will undo this revert once we
can resolve that failure.
jelbourn added a commit to jelbourn/components that referenced this pull request Sep 6, 2019
@jelbourn
fix(icon): use ErrorHandler to log MatIcon errors
11f3052 
This reverts commit 680ed00, which
reverted angular#16967 (roll forward)
@jelbourn jelbourn mentioned this pull request Sep 6, 2019
Merged
jelbourn added a commit that referenced this pull request Sep 13, 2019
@jelbourn
fix(icon): use ErrorHandler to log MatIcon errors (#16999)
4778f49 
This reverts commit 680ed00, which
reverted #16967 (roll forward)
jelbourn added a commit to jelbourn/components that referenced this pull request Sep 24, 2019
@jelbourn
fix(icon): use ErrorHandler to log MatIcon errors (angular#16999)
8f54f5c 
This reverts commit 680ed00, which
reverted angular#16967 (roll forward)

(cherry picked from commit 4778f49)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jermowery @jelbourn @googlebot