Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slide-toggle): clear static aria attributes from host nodes #17085

Merged
merged 1 commit into from
Sep 18, 2019

Conversation

crisbeto
Copy link
Member

Follow-up from #16938. Clears the aria-* attributes from the host node so that they're not duplicated with the underlying input.

Follow-up from angular#16938. Clears the `aria-*` attributes from the host node so that they're not duplicated with the underlying `input`.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Sep 14, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 14, 2019
@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 16, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit fb390fb into angular:master Sep 18, 2019
jelbourn pushed a commit to jelbourn/components that referenced this pull request Sep 24, 2019
…lar#17085)

Follow-up from angular#16938. Clears the `aria-*` attributes from the host node so that they're not duplicated with the underlying `input`.

(cherry picked from commit fb390fb)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants