Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(youtube-player): errors during server-side rendering #17091

Merged
merged 1 commit into from
Sep 16, 2019
Merged

fix(youtube-player): errors during server-side rendering #17091

merged 1 commit into from
Sep 16, 2019

Conversation

crisbeto
Copy link
Member

Fixes the youtube-player component throwing errors if it's rendered on the server. Also does some minor code cleanup.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Sep 15, 2019
@crisbeto crisbeto requested a review from jelbourn as a code owner September 15, 2019 16:27
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 15, 2019
devversion
devversion approved these changes Sep 16, 2019
View reviewed changes
@crisbeto
fix(youtube-player): errors during server-side rendering
a72672a 
Fixes the `youtube-player` component throwing errors if it's rendered on the server. Also does some minor code cleanup.
jelbourn
jelbourn approved these changes Sep 16, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker pr: merge safe labels Sep 16, 2019
@jelbourn jelbourn merged commit 59b0ee4 into angular:master Sep 16, 2019
jelbourn pushed a commit to jelbourn/components that referenced this pull request Sep 24, 2019
@crisbeto @jelbourn
fix(youtube-player): errors during server-side rendering (angular#17091)
9b547b9 
Fixes the `youtube-player` component throwing errors if it's rendered on the server. Also does some minor code cleanup.

(cherry picked from commit 59b0ee4)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @devversion @googlebot