Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(menu): trigger should aria-controls panel #17365

Merged
merged 3 commits into from
Oct 15, 2019
Merged

fix(menu): trigger should aria-controls panel #17365

merged 3 commits into from
Oct 15, 2019

Conversation

mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Oct 11, 2019
@mmalerba mmalerba requested a review from jelbourn October 11, 2019 00:14
@mmalerba mmalerba requested a review from crisbeto as a code owner October 11, 2019 00:14
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 11, 2019
@mmalerba mmalerba changed the title fix(menu): trigger should aria-owns panel fix(menu): trigger should aria-controls panel Oct 11, 2019
crisbeto
crisbeto reviewed Oct 11, 2019
View reviewed changes
jelbourn
jelbourn approved these changes Oct 11, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for aria-controls, can mark merge-ready once the mdc menu is covered

@mmalerba mmalerba mentioned this pull request Oct 11, 2019
Merged
@mmalerba mmalerba added this to the 9.0.0 milestone Oct 11, 2019
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Oct 11, 2019
@mmalerba mmalerba merged commit 405f5d0 into angular:master Oct 15, 2019
@mmalerba mmalerba deleted the menu-a11y branch October 15, 2019 18:08
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto left review comments

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mmalerba @jelbourn @crisbeto @googlebot