Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(paginator): add provider to configure default options #17595

Merged
merged 1 commit into from
Jan 24, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 3, 2019

Adds the MAT_PAGINATOR_CONFIG provider that allows consumers to configure the default options for all paginators in a module.

Also reworks the test setup to make it a bit more flexible.

Fixes #17123.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release labels Nov 3, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 3, 2019
@crisbeto crisbeto force-pushed the 17123/paginator-defaults branch from 4a12cf4 to cffe38c Compare November 9, 2019 22:52
@crisbeto
Copy link
Member Author

crisbeto commented Nov 9, 2019

Changed the naming based on the discussion @jelbourn.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added blocked This issue is blocked by some external factor, such as a prerequisite PR pr: lgtm action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Nov 18, 2019
@jelbourn

This comment has been minimized.

@mmalerba mmalerba removed the blocked This issue is blocked by some external factor, such as a prerequisite PR label Jan 10, 2020
Adds the `MAT_PAGINATOR_CONFIG` provider that allows consumers to configure the default options for all paginators in a module.

Fixes angular#17123.
@crisbeto crisbeto force-pushed the 17123/paginator-defaults branch from cffe38c to 31840ca Compare January 20, 2020 20:43
@jelbourn jelbourn merged commit c7c6262 into angular:master Jan 24, 2020
yifange pushed a commit to yifange/components that referenced this pull request Jan 30, 2020
…7595)

Adds the `MAT_PAGINATOR_CONFIG` provider that allows consumers to configure the default options for all paginators in a module.

Fixes angular#17123.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow globally configurable Mat Paginator Defaults
5 participants