Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): not respecting form control updateOn: blur for invalid values #18063

Merged
merged 1 commit into from
Dec 29, 2019

Conversation

crisbeto
Copy link
Member

Fixes the datepicker input not respecting when a FormControl is set to updateOn: 'blur' when changing between invalid values. The input was emitting for each change like the default.

Fixes #16461.

…id values

Fixes the datepicker input not respecting when a `FormControl` is set to `updateOn: 'blur'` when changing between invalid values. The input was emitting for each change like the default.

Fixes angular#16461.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Dec 29, 2019
@crisbeto crisbeto requested a review from mmalerba as a code owner December 29, 2019 18:24
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2019
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 29, 2019
@mmalerba mmalerba merged commit 61029c8 into angular:master Dec 29, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FormControl updateOn blur mode not working properly only for datepicker control.
3 participants