Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ripple positioning is off beneath the fold #1817

Closed
kara opened this issue Nov 11, 2016 · 1 comment · Fixed by #1907
Closed

Ripple positioning is off beneath the fold #1817

kara opened this issue Nov 11, 2016 · 1 comment · Fixed by #1907
Labels
P2 The issue is important to a large percentage of users, with a workaround

Comments

@kara
Copy link
Contributor

kara commented Nov 11, 2016

To repro:

  1. Slow animations down in animations console (because we are not robots).
  2. Remove "fullscreen" attribute from demo app sidenav.
  3. Move button (or other ripple container) to the bottom of the page, so that you have to scroll to get to it.
  4. Click the button.

You can see that the ripple originates from the bottom and not the center of the click event. It also takes a bit longer to appear.

Edit: it looks like the height of the ripple foreground wasn't taking into account the scrollTop of the page. So the height would be off by as far as the user had scrolled, making the ripple huge and centered far below (which is why we were only seeing the top later). Should be fixable by subtracting the scroll offset from the pageX and pageY.

@jelbourn jelbourn added the P2 The issue is important to a large percentage of users, with a workaround label Nov 11, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
3 participants