Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(material-experimental/chip): Add focus indicators #18261

Merged
merged 5 commits into from
Jan 24, 2020
Merged

feat(material-experimental/chip): Add focus indicators #18261

merged 5 commits into from
Jan 24, 2020

Conversation

zelliott
Copy link
Collaborator

@zelliott zelliott commented Jan 22, 2020 •
edited
Loading

  • Added three different kinds of focus indicators to MDC chip:
    • Added a focus indicator for when the chip itself is focusable.
    • Added a focus indicator for when the text inside the chip is focusable.
    • Added a focus indicator for when the "Remove" icon inside the chip is focusable.
  • In order to add a focus indicator for the chip itself, the chip is no longer the RippleTarget. Now, there is a dedicated ripple target element within the chip.
  • Added UT coverage.

Note: I'm not sure why it shows up with 5 commits... I can fix it if reviewers would like but I'm not sure it's actually a problem.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 22, 2020
@zelliott zelliott marked this pull request as ready for review January 22, 2020 21:35
@zelliott zelliott requested a review from mmalerba as a code owner January 22, 2020 21:35
jelbourn
jelbourn approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added G This is is related to a Google internal issue pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 24, 2020
@jelbourn jelbourn merged commit a5e13e2 into angular:focus-indicator Jan 24, 2020
jelbourn pushed a commit that referenced this pull request Jan 28, 2020
@zelliott @jelbourn
feat(material-experimental/chip): add focus indicators (#18261)
5170b34
mmalerba pushed a commit that referenced this pull request Feb 4, 2020
@zelliott @mmalerba
feat(material-experimental/chip): add focus indicators (#18261)
4f06a8b
mmalerba pushed a commit that referenced this pull request Feb 4, 2020
@zelliott @mmalerba
feat(material-experimental/chip): add focus indicators (#18261)
3f57aeb
mmalerba pushed a commit that referenced this pull request Feb 12, 2020
@zelliott @mmalerba
feat(material-experimental/chip): add focus indicators (#18261)
7581191
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

@vanessanschmitt vanessanschmitt Awaiting requested review from vanessanschmitt

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zelliott @jelbourn @googlebot