feat(material-experimental/mdc-form-field): support theming through feature targeting #18265
Conversation
devversion
added
the
target: patch
googlebot
added
the
cla: yes
devversion
force-pushed
the
feat/mdc-form-field-theming
branch
from
4f9a9ba to
fbf99c2
Compare
| @@ -0,0 +1,63 @@ | |||
| @use 'sass:color'; | |||
| @use '@material/theme/variables' as theme-variables; | |||
There was a problem hiding this comment.
As mentioned in the meeting. The variable value expressions are basically just copied over from their variables.scss file. I didn't bother updating every function invocation / variable reference to use the old syntax. Since the MDC styles already use @use and @forward anyway, I don't think there is any reason why we can't use it here (and save some work)
| // that the ripples are not rendered in the outline appearance, we copy the mixin call but | ||
| // increase the specificity. | ||
| .mat-mdc-text-field-wrapper.mdc-text-field--outlined { | ||
| @include mdc-ripple.states-base-color(transparent); |
There was a problem hiding this comment.
This mixin seems to be explicitly filtered out in mixins.import. I don't know why it isn't exposed there. Importing it through mixins.scss works. This matches how MDC text-field imports it, so I don't think it's wrong doing that here too.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
cc. @crisbeto
We can add support for toggling animations in a follow-up by filtering the animations feature target.